springwolf / springwolf-core

Automated documentation for event-driven applications built with Spring Boot
https://www.springwolf.dev
Apache License 2.0
255 stars 77 forks source link

Add BiFunction support to spring-cloud-stream-plugin #1087

Closed LeovR closed 1 day ago

netlify[bot] commented 2 days ago

Deploy Preview for springwolf-ui ready!

Name Link
Latest commit 3f0c3e33707c8116db345218fd648530f5c3ba8c
Latest deploy log https://app.netlify.com/sites/springwolf-ui/deploys/673e1064de23b900087d610c
Deploy Preview https://deploy-preview-1087--springwolf-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

LeovR commented 2 days ago

I think I have to dig deeper into the Kafka Streams Binder which behaves differently compared to the regular Kafka Binder. At first look it seems that the Kafka Streams Binder does not use the FunctionCatalog like the regular Kafka Binder does. The semantic seems to be different for the BiFunction types depending on the binder implementation.

timonback commented 1 day ago

Fair enough, KStreams might be completely different anyway.

Since I do not use cloud stream in production, my knowledge is limited and I am very grateful for your input.

I'll merge the PR as it is good as it is right now. Feel free to open more PRs, and/or reopen the original issue.