search

sprintaway / pe

0 stars 0 forks source link

Inconsistent error message #7

Open sprintaway opened 2 years ago

sprintaway commented 2 years ago

image.png

image.png

The error message should say supplier instead of person.

nus-pe-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Inconsistent error message when finding suppliers

Screenshot 2022-11-11 at 5.07.36 PM.png Screenshot 2022-11-11 at 5.07.36 PM

When executing find n/ hello to find a supplier with hello in the name, the error message instead refers to the found suppliers as 'persons'.

This is inconsistent and can be confusing for users, especially since the listSuppliers command refers to them as suppliers, not persons. Screenshot 2022-11-11 at 5.09.06 PM.png

I would expect all reference to suppliers to show "suppliers" instead of the default AB3 persons.

[original: nus-cs2103-AY2223S1/pe-interim#3698] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

I agree that all reference to suppliers should show "suppliers" instead of "persons". However, it is a typo and purely cosmetic issue in the UI and it does not affect the normal operations of the application usage at all. Hence I propose that the original severity of medium is too high and change it to veryLow.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]