sprintly / sprintly-kanban

A Kanban Board for Sprintly
https://kanban.sprint.ly
ISC License
493 stars 81 forks source link

Header component + product selector page styling #12

Closed wookiehangover closed 9 years ago

wookiehangover commented 9 years ago

What does it do?

Splits out the header into it's own component, adding the missing account dropdown. With the new header component in place, we're able to make quick work of prettying-up the product chooser landing page.

Also, dropdown styles were updated to be more faithful to the main site.

Where should the reviewer start?

app/views/components/header.js - new component shared between kanban view and product selector app/views/components/gravatar.js - created to share gravatar stuff between item cards and the account dropdown in the header app/views/pages/product-selector.js - added some react-bootstrap components for quick + easy styling benefits

How should it be manually tested?

The header will be on both views in the app and the product selector should have updated styles.

Screenshots

Accounts dropdown: screen shot 2015-04-02 at 9 38 26 pm

Product selector: screen shot 2015-04-03 at 8 48 45 am

GIF?

tumblr_lt8texgw9k1qz9shlo1_500

ps I swear this is the last PR from me this week...

wookiehangover commented 9 years ago

@justinabrahms took your suggestion from slack to pull in the Labs branding and make a ticket: http://sprint.ly/i/1/9601/ , and Brian is already working on a comp for it.

All things being equal, I'd like to land this stuff now and then circle back once the comp is ready. Sound good?

justinabrahms commented 9 years ago

Curious about svg, but :+1: