sprintly / sprintly-kanban

A Kanban Board for Sprintly
https://kanban.sprint.ly
ISC License
493 stars 81 forks source link

Flux Refactor + SubItems UI #24

Closed wookiehangover closed 9 years ago

wookiehangover commented 9 years ago

What does it do?

This depends on upstream changes in sprintly-data https://github.com/sprintly/sprintly-data/pull/16

Where should the reviewer start?

This seems like a big changeset, but most of it is copying methods and tests between app/stores/product-store.js and app/actions/product-actions.js.

Subitems changes come nested within their parent items directly from sprintly-data, so the only changes we needed to account for were global settings for product API requests and additional comonents within ItemCard.

How should it be manually tested?

Head over to https://sprintly-manifold.herokuapp.com/product/1 and give it a test drive!

Background context

The reason for the flux refactor was to get our data flow to better align with the Flux pattern. Instead of relying on backbone events to trigger re-renders, our store now emits it's own events, and the store implementation has less knowledge of server interactions.

User Interaction --> ActionCreator calls API --> Action Dispatched --> Store emits change

Screenshots

screen shot 2015-05-14 at 4 49 14 pm

phoenixbox commented 9 years ago

@wookiehangover seems good - nothing apart from nitpicks - there are some pending xdescribe tests also but :shruggie: