Closed fluxusfrequency closed 9 years ago
@fluxusfrequency apart from the nits looks solid :+1: :clap:
Also that gif continually amazes me - could watch on repeat
Thanks for the review. I'm going to address some of these in the parent PR.
@wookiehangover rebased master into this, ready for further review
This has the styling changes merged in @wookiehangover
@fluxusfrequency didn't we talk about moving the form into a popover?
Either way, that form should not be inline because there's no indication that you can edit it or what you're changing (or when it's changed.)
@wookiehangover this was from before we had that conversation. I'm waiting on updating the styling for the comp you said you were going to make.
I suppose putting it all into a popover kind of goes beyond the "styling" barrier though.
Per our conversation in Slack, it looks like I misunderstood what you want. I'll move the velocity input form into the popover.
What's this PR do?
Allows a user to adjust the predicted velocity for the current session (will not persist when the window is refreshed).
Any background context or notes you want to provide?
Builds on #27. Once that's merged, this should be fairly small (only commits from 5/22 forward).
Which code should the reviewer start with?
app/views/components/filters/filters-toolbar.js
How is this feature tested (either manually or automatically)?
Use this input. The backlog should change.
What are the relevant tickets (please include link(s))?
https://sprint.ly/product/1/item/9848
What gif best describes this PR or how it makes you feel?
Definition of Done: