sprintly / sprintly-kanban

A Kanban Board for Sprintly
https://kanban.sprint.ly
ISC License
493 stars 81 forks source link

9848 adjust velocity #28

Closed fluxusfrequency closed 9 years ago

fluxusfrequency commented 9 years ago

What's this PR do?

Allows a user to adjust the predicted velocity for the current session (will not persist when the window is refreshed).

Any background context or notes you want to provide?

Builds on #27. Once that's merged, this should be fairly small (only commits from 5/22 forward).

Which code should the reviewer start with?

app/views/components/filters/filters-toolbar.js

How is this feature tested (either manually or automatically)?

Use this input. The backlog should change.

screen shot 2015-05-22 at 12 15 59 pm

What are the relevant tickets (please include link(s))?

https://sprint.ly/product/1/item/9848

What gif best describes this PR or how it makes you feel?

Definition of Done:

phoenixbox commented 9 years ago

@fluxusfrequency apart from the nits looks solid :+1: :clap:

phoenixbox commented 9 years ago

Also that gif continually amazes me - could watch on repeat

fluxusfrequency commented 9 years ago

Thanks for the review. I'm going to address some of these in the parent PR.

fluxusfrequency commented 9 years ago

@wookiehangover rebased master into this, ready for further review

fluxusfrequency commented 9 years ago

This has the styling changes merged in @wookiehangover

wookiehangover commented 9 years ago

@fluxusfrequency didn't we talk about moving the form into a popover?

Either way, that form should not be inline because there's no indication that you can edit it or what you're changing (or when it's changed.)

fluxusfrequency commented 9 years ago

@wookiehangover this was from before we had that conversation. I'm waiting on updating the styling for the comp you said you were going to make.

fluxusfrequency commented 9 years ago

I suppose putting it all into a popover kind of goes beyond the "styling" barrier though.

fluxusfrequency commented 9 years ago

Per our conversation in Slack, it looks like I misunderstood what you want. I'll move the velocity input form into the popover.

fluxusfrequency commented 9 years ago

screen shot 2015-05-29 at 10 17 50 am