netlify[bot]
commented
9 months ago Deploy Preview for bmeof-v2 ready!
| Name | Link |
|---|---|
| Latest commit | b21199cf0f9d73390862359ec0cde446a0c4a446 |
| Latest deploy log | https://app.netlify.com/sites/bmeof-v2/deploys/65bb71ab96fdab0007fa2a5c |
| Deploy Preview | https://deploy-preview-46--bmeof-v2.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
johnnycrisp
The reason this fix is needed is that the custom kerning requirements that translate individual letters up and down by certain percentages create a space at the foot of the container. This gap is filled to a certain extent by the footer, however on larger screens this this gap increases as the font size is linked to the screenwidth for the large text. We can not simply put overflow hidden on the container as this cuts off the text when we hover on the right of the screen. This need for both custom kerning AND hover right means we are stuck doing something a little fiddly to fix this (and many other things).
SO. I have slightly decreased the font size on all the text (I think this as low as we can go without discussing with BMEOF) and adding a tiny bit of padding on the top of the footer.
This will need to be checked on a few devices and browsers to make sure I have completely covered the gap. Please check on mobile as well. I do not want to launch something half fixed as we have done that a few times recently and it is probably going to start annoying the client at some point.
There is a possibility that if this doesn't cover enough and the gap appears on larger screens then you could make padding top on the footer a vw unit.
When you do merge and show BMEOF can you tell them (in simplified terms) what we have done and check he is OK with that.