search

spro / practical-pytorch

Go to https://github.com/pytorch/tutorials - this repo is deprecated and no longer maintained
MIT License
4.52k stars 1.11k forks source link

Train and Test Split #124

Open rjtmehta99 opened 5 years ago

rjtmehta99 commented 5 years ago

In the Char RNN classification I had some questions:

  1. Why have not split the dataset into train and test/validation set to check the performance ?
  2. How can we add 'accuracy' as a metric to evaluate model performance ?
masalha-alaa commented 3 years ago

I agree with this. Currently he tests on the training data, and draws a misleading confusion matrix. He trains on 100K names with repetitions, and tests against 10K from the same population, yet again with repetition. You can't infer accuracy from this. You need to split to train / test and evaluate on the test after every epoch. Please see my notebook.