spro / practical-pytorch

Go to https://github.com/pytorch/tutorials - this repo is deprecated and no longer maintained
MIT License
4.51k stars 1.1k forks source link

Error in practical-pytorch/seq2seq-translation/seq2seq-translation-batched.ipynb #136

Open xiaolan98 opened 4 years ago

xiaolan98 commented 4 years ago

In class BahdanauAttnDecoderRNN, Should "word_embedded = self.embedding(word_input).view(1, 1, -1) # S=1 x B x N" be " word_embedded = self.embedding(word_input).view(1, word_input.size(0), -1) # S=1 x B x N"? Because in the case of this tutorial, batch_size is not equal to 1.(word_input.size(0) is the batch_size)