sprocket-9 / hacs-nuvo-serial

Custom component to control a Nuvo Grand Concerto/Essentia G multi-zone amplifier via serial connection
MIT License
9 stars 1 forks source link

Allowing connection via Music Port ( #9

Closed Greg81 closed 10 months ago

Greg81 commented 1 year ago

I own an old music port, which sits between my Grand Concerto and my PC. It supports the entire stack of commands, but changes one little thing that breaks the implementaiton. When querying *VER to the serial port, the response is two lines, where the first one can be ignored:

VER"NV-NNA FWv1.08 HWv0"

VER"NV-I8G FWv2.66 HWv0"

I would love to keep the music port connected as is, since I do not think it will break anything. I have tried to look at the code in order to find where the model is defined.

Apparently this is done in: from nuvo_serial.const import MODEL_GC but I cannot find a definition of MODEL_GC in any of the files.

Therefore it appears that I am not sufficiently well-versed in git (and / or python) to fix this myself and submit a proposed change. Can you help?

The00Dustin commented 1 year ago

I suspect you need to look at https://github.com/sprocket-9/nuvo-serial instead of this repo, which is for the HomeAssistant custom component using the same.

sprocket-9 commented 1 year ago

Assuming you are using Home Assistant, to get a clearer idea I really need to see a full log with debug logging enabled for nuvo_serial integration - this has the query/response output of the integration talking to the Nuvo.

Try adding this to configuration.yaml and restarting HA:

logger:
  default: info
  logs:
    nuvo_serial: debug

You can try pasting the log in your reply here if it formats ok and is readable, or at https://privatebin.at/ but the file may be too big - either filter the log file with lines containing "nuvo" or use something like dropbox if that's the case.

I don't have a music port device myself but I'm surprised no one else using this component has one. But if they are and the system responds to the VER command as you say, then the component wouldn't work for them either as the Version check will fail, so maybe not and you are the first. Could be more problems having a music port in front of the GC than just this version check problem, which may mean I won't support it, but lets see.

Couple of things to try:

In message.py of the nuvo-serial library https://github.com/sprocket-9/nuvo-serial/blob/main/nuvo_serial/message.py#L345 Change:

models = {"NV-I8G": MODEL_GC, "NV-E6G": MODEL_ESSENTIA_G}

To:

models = {"NV-NNA": MODEL_GC, "NV-E6G": MODEL_ESSENTIA_G}

If that doesn't work, access the component files on your HA system and try bypassing the version check. Look for the get_nuvo_async function calls in config_flow.py and __init__.py files. Add an argument of do_model_check=False to each one you find. I've not tested this bypass with HA before so fingers crossed...

If that gets you up and running then give the component a full test and report if any more issues pop up due to the music port's presence.

Greg81 commented 1 year ago

Thanks to all suggestions. I have removed the "nuvo port / nuvo net" adapter in between and it now seems to be working.

On Sat, Jul 29, 2023 at 9:41 PM sprocket-9 @.***> wrote:

Assuming you are using Home Assistant, to get a clearer idea I really need to see a full log with debug logging enabled for nuvo_serial integration - this has the query/response output of the integration talking to the Nuvo.

Try adding this to configuration.yaml and restarting HA:

logger: default: info logs: nuvo_serial: debug

You can try pasting the log in your reply here if it formats ok and is readable, or at https://privatebin.at/ but the file may be too big - either filter the log file with lines containing "nuvo" or use something like dropbox if that's the case.

I don't have a music port device myself but I'm surprised no one else using this component has one. But if they are and the system responds to the VER command as you say, then the component wouldn't work for them either as the Version check will fail, so maybe not and you are the first. Could be more problems having a music port in front of the GC than just this version check problem, which may mean I won't support it, but lets see.

Couple of things to try:

In message.py of the nuvo-serial library https://github.com/sprocket-9/nuvo-serial/blob/main/nuvo_serial/message.py#L345 Change:

models = {"NV-I8G": MODEL_GC, "NV-E6G": MODEL_ESSENTIA_G}

To:

models = {"NV-NNA": MODEL_GC, "NV-E6G": MODEL_ESSENTIA_G}

If that doesn't work, access the component files on your HA system and try bypassing the version check. Look for the get_nuvo_async function calls in config_flow.py and init.py files. Add an argument of do_model_check=False to each one you find. I've not tested this bypass with HA before so fingers crossed...

If that gets you up and running then give the component a full test and report if any more issues pop up due to the music port's presence.

— Reply to this email directly, view it on GitHub https://github.com/sprocket-9/hacs-nuvo-serial/issues/9#issuecomment-1656852137, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI77YV6AJQO34SA4OX345DXSVROLANCNFSM6AAAAAA2CNE5DY . You are receiving this because you authored the thread.Message ID: @.***>