search

sproctor / php-calendar

PHP-Calendar
http://www.php-calendar.org/
Apache License 2.0
138 stars 67 forks source link

Festivities #44

Open sabas opened 11 years ago

sabas commented 11 years ago

Different color for days which are: -national / local festivities -other days off

sproctor commented 11 years ago

We could expand categories to cover this issue. Maybe have full day events with categories change the background for the entire day. Or add another category attribute that does it.

sabas commented 11 years ago

"change the background for the entire day" <- what about css classes? and some definition for rules to apply them (if festivity add .festivity class to the div)

sproctor commented 11 years ago

The same logic applies for classes as it does for any kind of style. For something programmatic like this, it's easier to add the style to each place it's to be applied. I'm not sure that we want users to have too much control over the CSS as it opens up a path to XSS and similar attacks.

madahmani commented 11 years ago

The idea is very much interesting and a simple class, similar to Twitter Bootstrap styles may be applied. The user will then have the possibility of assigning a color to each festivity.