sproogen / modern-resume-theme

A modern static resume template and theme. Powered by Jekyll and GitHub pages.
https://sproogen.github.io/modern-resume-theme/
MIT License
2.09k stars 1.4k forks source link

Feature: Automatic dark mode triggering #178

Closed alirezadizaji closed 1 year ago

alirezadizaji commented 1 year ago

Hi,

I implemented a feature to enable triggering dark mode automatically by developing a workflow. Beforehand, users should set a variable called trigger_darkmode, which by default is null meaning to disable this feature. If not null, then this variable should contain two keys: start_light and start_dark, indicating the hour to start light and dark mode respectively. Both should have the HH format.

sproogen commented 1 year ago

I think this is probably a bit of an overkill for triggering darkmode on a schedule. A simpler approach would be checking the status in the browser instead of a cron job to update the config and re deploy. But I think keeping a static option for dark mode is fine for now.