search

sprotheroe / vagrant-disksize

Vagrant plugin to resize disks in VirtualBox
MIT License
479 stars 51 forks source link

Resize fails when first device is not a disk (e. g. is a DVD or floppy) #14

Closed EmersonPrado closed 6 years ago

EmersonPrado commented 6 years ago

Method Vagrant::Disksize::Action.identify_disks returns all storage devices attached to the VM. All methods which deal with disks reference the first device. If this first device is a CD/DVD/floppy, cloning will (thankfully) fail:

There was an error while executing `VBoxManage`...
Command: ["clonemedium", "<CD/DVD/floppy path>", "<Same changed to vdi>", "--format", "VDI"]
Stderr: VBoxManage: error: The medium '<CD/DVD/floppy path>' can't be used as the requested device type

There should be a filter assuring the method will only return an actual disk.

EmersonPrado commented 6 years ago

Opened PR 15

sprotheroe commented 6 years ago

Merged your PR - thanks!