Rename `with` to `with_args`

sproutapp / pavlov

A BDD framework for your Elixir projects

MIT License

128 stars 7 forks source link

Rename `with` to `with_args` #49

Closed mgwidmann closed 8 years ago

mgwidmann commented 8 years ago

Elixir 1.2 causes a compile error:

cannot import Pavlov.Mocks.Matchers.with/2 because it conflicts with Elixir special forms

Lots of warnings are still printed, but this PR does not address that issue.

Closes #48

mgwidmann commented 8 years ago

Any status on if this is good to merge or not?

inf0rmer commented 8 years ago

Hello! Sorry for the blackout, I was on vacation until recently :).

The code looks fine, thanks for the fix! May I ask you to also change the Mocks with arguments section on the README file to reflect the change from with to with_args?

Thank you for the contribution!

mgwidmann commented 8 years ago

Oh sure, didn't see that spot!