search

sproutcore / abbot

SproutCore Build Tools [deprecated]
http://www.sproutcore.com
88 stars 44 forks source link

Fix install on JRuby #110

Closed VShell closed 10 years ago

VShell commented 10 years ago

As part of a Java-based build system, I'd like to run Sproutcore under JRuby. These patches allow it to build and run under JRuby 1.7.12; older versions may or may not work. The proxy functionality in the server would need to be fixed not to depend on thin for that to work.

Note that with these patches, Sproutcore will still have to be built from source under JRuby, as the gemspec is run at build time, not install time. To fix this, a workaround like this would have to be used, which uses an extension definition to choose which gems to install at install

VShell commented 10 years ago

I've removed the dependency on thin from the proxy, but haven't tested it yet (either under JRuby or ordinary Ruby). Hold off on merging this.

VShell commented 10 years ago

Alright, fixing the proxy would be significantly more effort than I thought. "async.callback" follows a different specification in Mizuno than in Thin, and I also seem to be getting thrown an error by something, but I'm not sure what.

I asked in channel about the new build tools, and apparently they're probably in a working state, so I'm personally going to switch my efforts to integrating them into my build system and close this pull request.

dcporter commented 10 years ago

Sounds good. Thanks very much for this effort, and I look forward to seeing you over on the node side!