search

sproutcore / abbot

SproutCore Build Tools [deprecated]
http://www.sproutcore.com
88 stars 44 forks source link

Bundling Error: Abbot sends javascript-packed.js files when :used_packed == false #18

Open FrozenCanuck opened 13 years ago

FrozenCanuck commented 13 years ago

See:

https://github.com/sproutcore/abbot/commit/1600bf2ae36cead9bcb5cf222c76c029e75c7f9c

Without the fix clobbering occurs causing unexpected results when running a SproutCore application. Fix has been applied; just need to be merged into origin/1-4-stable. Has been reviewed by Tom Dale.

wagenet commented 13 years ago

Looks good to me, but I need to test it.

FrozenCanuck commented 13 years ago

Sounds good. Tom ran the fix on his end and confirmed everything went as expected. Hopefully you'll get the same result.

wycats commented 13 years ago

Does this still need to be merged into 1-4-stable?

FrozenCanuck commented 13 years ago

Yes, it should. I haven't merge the changes because I wanted some others to review. Peter and Tom both said my update looked fine. I can merge it in if you'd like.

wagenet commented 13 years ago

Is this still an issue?

FrozenCanuck commented 13 years ago

it is in 1.4.x, not sure about 1.5 since bundling has been replaced with modules. I haven't looked at the new module logic.

wagenet commented 13 years ago

Ok, since it's only verified on 1.4 feel free to merge yourself or just close it. If there's also an issue on 1.5 we can make a new ticket for it.

FrozenCanuck commented 13 years ago

Sure, I'll merge into 1.4-stable branch and close.

wagenet commented 13 years ago

Guess we should release a new 1.4 at some point.

wagenet commented 13 years ago

@FrozenCanuck, what's the status of this?