sproutcore / abbot

SproutCore Build Tools [deprecated]
http://www.sproutcore.com
88 stars 44 forks source link

Please pull in changes to enable JsTestDriverIntegration #31

Closed paulitex closed 13 years ago

paulitex commented 13 years ago

Hi, as discussed on the mailing list http://groups.google.com/group/sproutcore/browse_thread/thread/b7b09ee4dab036d8 these changes add a feature to abbot to support JsTestDriver. I documented the tool here: http://paulitex.com/2011/02/integrating-jstestdriver-with-sproutcore/.

Since some people (in particular Martin Hacker on the ML) asked for me to 'make this easily availeable for other sproutcore users' I thought I'd send the request now.

Comments are very welcome,

Paul

tomdale commented 13 years ago

I'm okay with these kind of things because a) we do not have a plugin architecture, and b) they do not add any overhead to the payload delivered to the browser.

However, I'm uncomfortable with this adding yet another dependency, as we already have too many. Can you detect if nokogiri is installed and throw an error if it is not? There's no point in burdening all users with an extra dependency if they won't be using JsTestDriver.

Thanks!

wagenet commented 13 years ago

@paulitex are you able to make these changes?

paulitex commented 13 years ago

Yes I am - sorry about that I got really busy and kinda forgot about this. Thanks for the poke. :) I'll look into it asap

workmanw commented 13 years ago

Bump. Paulitex are you still working on this. We're using JSTD and we'd like to see it make it into Abbot so we don't have to patch abbot on our side.

paulitex commented 13 years ago

to be honest, I'd love to say yes but as my 3 months 'asap' may reveal, this is near the bottom of a very big (and growing) stack of todos :(. If you want to pull my fork, incorporate Tom's suggestion, and open a new pull request by all means and we'll close this one. sorry about that.

workmanw commented 13 years ago

@paulitex No biggie, I know how that goes. I did create a branch, merged your changes in, made the modifications Tom requested and submitted a pull request. Thanks for putting in the initial effort to make js-test-driver work :)

~Wesley

paulitex commented 13 years ago

Awesome :)