search

sproutcore / abbot

SproutCore Build Tools [deprecated]
http://www.sproutcore.com
88 stars 44 forks source link

Add a blacklist to the build tools #61

Closed gmoeck closed 13 years ago

gmoeck commented 13 years ago

A whitelist works great when your starting a project, but if your starting to remove files at the end it is helpful to be able to blacklist instead. In order to accomplish these changes I also added unit tests for both the whitelist and the blacklist, and refactored how the whitelist was working.

publickeating commented 13 years ago

I don’t really know how the Whitelist works. If you want to white/black list different apps separately within the same project is that possible?

As an aside, I did a search and couldn’t find any documentation on using the existing Whitelist. Since you’re familiar with it, do you think you could write a blurb in the guide to go along with these changes? Or maybe a short blog post? Let me know if you’re too busy and I can do it when I get a moment.

gmoeck commented 13 years ago

Currently if there is a whitelist that takes priority over the blacklist since I figured that would be safer to ensure legacy compatibility as there were no existing tests for this feature. It doesn't really make sense to have both in an application at the same time, since you would have to explicitly whitelist something, and then blacklist the thing that is in your whitelist for that to ever even have an effect.

The only documentation that I've ever seen is when Colin public gisted a list of an old whitelist for one of our apps. I certainly could do some sort of quick writeup, but since all the momentum seems to be going to 2.0, I'm not sure if from a marketing standpoint this would be a good idea as a blog post. It almost seems like a link to an example whitelist or blacklist would be sufficient.

publickeating commented 13 years ago

Agree about not being a blog post.

What I meant was if I have a project, my_project, with two apps inside of it: my_project/desktop & my_project/iphone, can I have two whitelists (one for desktop and a different one for iphone)? It doesn’t make sense that the whitelist should apply to all apps within a project, which I suspect is how it works, but I’m not sure.