search

sproutcore / abbot

SproutCore Build Tools [deprecated]
http://www.sproutcore.com
88 stars 44 forks source link

Blacklist CSS #71

Closed joegaudet closed 12 years ago

joegaudet commented 13 years ago

Similar to the Blacklist that removes .js files that aren't used, it would be nice to have a way to guard against some of the default css being included that is not needed for my app. Or ultimately is being overriden, so for example I have my own style for SC.ButtonView that is pervasive throughout the app, it would be nice to be able to remove the additional css given that our current css payload is about 600 kb + 200 kb the 600kb is all SC.

.joe

ialexi commented 13 years ago

You can already do this: Whitelist/Blacklist works on both CSS and JS

Also, do you have Ace in addition to your own theme? If so, if your styling is all custom (rather than a variant of Ace) you don't need it; change it to SC.BaseTheme.create() (instead of AceTheme) and in your build file, set :theme to :theme => 'sproutcore/empty_theme'

joegaudet commented 13 years ago

OIC, cool. Now I just need the proxying error we keep seeing to get resolved and we will be cooking.

.joe

joegaudet commented 13 years ago

Which version of Abbot officially had Blacklist support ?

ialexi commented 13 years ago

I think 1.6 may have had some support, but it was broken (in that it used a different format than it should have). 1.7 has support.

joegaudet commented 13 years ago

On a related note, how do I go about removing the ace theme from the SC build.

I changed my theme to not use ace anymore, but rather EmptyTheme, however it still seems to package / send the ace SC stuff.

Do I need to black list it ?

.joe On 2011-09-20, at 3:44 PM, Alex Iskander wrote:

I think 1.6 may have had some support, but it was broken (in that it used a different format than it should have). 1.7 has support.

Reply to this email directly or view it on GitHub: https://github.com/sproutcore/abbot/issues/71#issuecomment-2150743

ialexi commented 13 years ago

You shouldn't need to... have you changed :theme in your app's build file to be :theme => 'sproutcore/empty_theme'?

ialexi commented 13 years ago

(Ace is just a target like any other; it has to be included via either :required => or :theme =>; by default, all apps default to :theme => "sproutcore/ace", but if that's turned off, there's no reason it should get included)