search

sproutcore / abbot

SproutCore Build Tools [deprecated]
http://www.sproutcore.com
88 stars 44 forks source link

Fixed confusion issues with design/create/extend usage. #87

Closed topherfangio closed 12 years ago

topherfangio commented 12 years ago

Fixed main_page.js to use .create() and .extend() instead of .design() for clarity as requested by geojeff and tce in IRC.

topherfangio commented 12 years ago

After discussing it with folks, we have decided to push this change off until we can talk to more people about the implications. We need to get 1.8 pushed out, so this will wait until later.

geoffreyd commented 12 years ago

I you do apply for this pull request again, design should only be replaced by extend, not create.

Remember that in a page, you classes, as the page will create in place in instance when it is first asked for.

topherfangio commented 12 years ago

So...your "Ozzie" is shining through here...I have no idea what you meant. Can you try again in "English" :-)

Sent from my iPhone

On Feb 29, 2012, at 6:15 PM, Geoffrey Donaldsonreply@reply.github.com wrote:

I you do apply for this pull request again, design should only be replaced by extend, not create.

Remember that in a page, you classes, as the page will create in place in instance when it is first asked for.

Reply to this email directly or view it on GitHub: https://github.com/sproutcore/abbot/pull/87#issuecomment-4249924

geoffreyd commented 12 years ago

Gah, stupid iOS autocorrect, doesn't understand Australian! :persevere:

and after all that, I have to take it back anyways! :flushed: ... I double checked with the SC source, what you've done here is correct :smile: