search

sproutcore / abbot

SproutCore Build Tools [deprecated]
http://www.sproutcore.com
88 stars 44 forks source link

Relax the json_pure dependency's version constraint to prevent Bundler conflicts in user applications #94

Closed artob closed 11 years ago

artob commented 11 years ago

Currently, the 'sproutcore' gem requires 'json_pure' with a version constraint of ~> 1.4.6. This is highly problematic in newer applications, leading to Bundler conflicts such as the following:

$ bundle 
Fetching gem metadata from https://rubygems.org/.........
Fetching gem metadata from https://rubygems.org/..
Bundler could not find compatible versions for gem "json_pure":
  In snapshot (Gemfile.lock):
    json_pure (1.7.5)

  In Gemfile:
    sproutcore (= 1.9.1) ruby depends on
      json_pure (~> 1.4.6) ruby

Given the stability of the 'json_pure' API, the version constraint ought to be specified in the less problematic form >= 1.4.6 that avoids creating these Bundler conflicts.

artob commented 11 years ago

Bump?

publickeating commented 11 years ago

I'm relaxing all the dependencies from being ultra-pessimistic (ex. ~> 1.4.6) to just being pessimistic (ex. ~> 1.4), so that should take care of your problem.

Just trying to do a bit of testing with the latest versions of the dependent gems and then this should go out in 1.9.2.