Closes #108 - TDD Guide doesn't properly attribute Greg Moeck.

sproutcore / guides

The guides source. Build and push to https://github.com/sproutcore-guides/sproutcore-guides.github.com.

http://guides.sproutcore.com/

110 stars 65 forks source link

Closes #108 - TDD Guide doesn't properly attribute Greg Moeck. #109

Closed topherfangio closed 12 years ago

topherfangio commented 12 years ago

Added proper attribution for Greg Moeck and updated the credits to include his name.

topherfangio commented 12 years ago

So, just for clarification, is this the proper way to submit a pull request?

Fork repo
Create an issue describing the problem
Create a branch in my fork to fix the issue
Make a pull request off of that branch that contains "Closes #XYZ" in the commit message

Thanks guys!

topherfangio commented 12 years ago

@ColinCampbell Thanks very much! Quick clarification: I noticed that the pull request creates an issue. Should I continue creating a separate issue to describe the problem, or let the pull request be the issue?

Thanks again!