search

sproutsocial / walltime-js

A JavaScript library for easily translating a UTC time to a "Wall Time" for a particular time zone.
MIT License
121 stars 12 forks source link

America/Regina timezone data invalid #29

Closed jacobg closed 11 years ago

jacobg commented 11 years ago

Running the following code in console:

WallTime.UTCToWallTime(new Date(), 'America/Regina').zone.name

Displays result "UTC".

It looks like something might be invalid in America/Regina zone data?

jacobg commented 11 years ago

Screen Shot 2013-04-22 at 9 42 23 AM

It looks like there is a problem with zone data as shown in attached screenshot.

jgable commented 11 years ago

When was the last time you updated your walltime.js and data files? We found an issue with zone lines that had an until rule that was a variable day like lastSun and pushed a fix for it.

It was piggy backed onto the --minyear merge in this commit: https://github.com/sproutsocial/walltime-js/commit/b0d9013573f1a6c63f9ff04ed38506664c4d29a5

The latest walltime-data.js and walltime-data-min.js should have the fixed data, otherwise you'll need to build the individual data files yourself again with the latest code.

jacobg commented 11 years ago

Thanks. I did a pull, but it doesn't look like walltime,js is in sync with those latest coffee files. What coffee command do you run to output walltime.js? Could you also add that to the readme please? Thanks a lot!

jacobg commented 11 years ago

Re-reading your comment, it seems that your fix is in walltime.js, not walltime-data.js? Am I incorrect?

jgable commented 11 years ago

cake build - It's already documented if you just type cake it outputs the options and descriptions. Not going to put it in the readme because most people shouldn't have to run it.

I've rebuilt and am pushing it up now.

jacobg commented 11 years ago

Awesome. Works great now. Thanks a ton!