search

sproutsocial / walltime-js

A JavaScript library for easily translating a UTC time to a "Wall Time" for a particular time zone.
MIT License
121 stars 12 forks source link

Unable to find time zone names America/St Barthelemy #49

Open monove opened 8 years ago

monove commented 8 years ago

Any ideas?

mattjohnsonpint commented 8 years ago

You need an underscore where you have a space.

monove commented 8 years ago

Uncaught Error: Unable to find time zone named America/St_Barthelemy (WallTime 0.2.0)

jgable commented 8 years ago

I think this is because the America/St_Barthelemy rule is really a Link to America/Guadeloupe. I don't think I ever implemented link situations.

robmadden commented 8 years ago

Whatever @jgable says is right, so just listen to him.

mattjohnsonpint commented 8 years ago

Yep, that would do it as well. I'd recommend supporting links. Zones occasionally move to links upon new versions of tzdb.

getaaron commented 8 years ago

I agree with @robmadden

monove commented 8 years ago

But how would I get a link mapping?

geedew commented 8 years ago

@robmadden ... @robmadden

az-tock commented 8 years ago

+1 @getaaron

jgable commented 8 years ago

Why do I feel like I'm being hazed? You know what the real hazing was, when I had to write this monstrosity for handling timezones in the first place.

Shouldn't people be using http://momentjs.com/timezone/ by now? They really do a much better job at this and they have like a million tests.

Man, and this library is written in CoffeeScript, talk about nobody else being able to maintain it. I'm stuck with this thing for life.

monove commented 8 years ago

"Moment Timezone has no data for America/St Barthelemy"

monove commented 8 years ago

never mnd that, i missed the underscore

mattjohnsonpint commented 8 years ago

@jgable - Despite jumping on the moment.js / moment-timezone bandwagon, I've also tried to give fair credit to alternatives like walltime (and a few others). Believe me, I considered answering this issue with "just use moment instead" - but thought you guys would frown on that. Would you prefer we consider walltime discontinued and move along? Just askin'. :)

jgable commented 8 years ago

I think it would be relatively clear from looking at the commits/pulse graph that this library isn't being maintained. I'm no longer at Sprout Social so I can't speak for them, but I'd be +1 to putting a notice in the readme.

soung3 commented 8 years ago

We're actually actively in the process of converting over to Moment.js at Sprout Social. We'll update the README to state the end of support, unless someone else wants to carry the torch.

mattjohnsonpint commented 8 years ago

Thanks for clarifying. If I can do anything to ease the transition, please let me know.