search

spruceid / siwe-py

A Python implementation of Sign-In with Ethereum
https://login.xyz
Apache License 2.0
66 stars 28 forks source link

Typing fixes + remove unneeded Address Type #43

Closed ameyarao98 closed 1 year ago

ameyarao98 commented 1 year ago

Minor fixes that pyright complained about, as well as removing the unneeded Address Type. The repo now passes pyright basic validation

sbihel commented 1 year ago

Could you bump the MSRV and CI to Python 3.8 and add pyright to the CI?

ameyarao98 commented 1 year ago

Could you bump the MSRV and CI to Python 3.8 and add pyright to the CI?

The MSRV does not have to be bumped here, I used to old Dict typing syntax so it's fine. I have added pyright to the CI

sbihel commented 1 year ago

You can disable pyright on windows and then it should be good to go

ameyarao98 commented 1 year ago

You can disable pyright on windows and then it should be good to go

What is the syntax for this :thinking: