search

spruceid / siwe-py

A Python implementation of Sign-In with Ethereum
https://login.xyz
Apache License 2.0
67 stars 30 forks source link

Remove rethrow of ValidationError as ValueError #58

Closed fubuloubu closed 6 months ago

fubuloubu commented 6 months ago

Makes this really hard to debug in a web service since FastAPI already translates ValidationError nicely, and ValueError doesn't show any additional context https://github.com/spruceid/siwe-py/blob/0da61e8e8cb42ad0a357880718bbb77471872a1e/siwe/siwe.py#L182-L185