spruceid / siwe-py

A Python implementation of Sign-In with Ethereum
https://login.xyz
Apache License 2.0
66 stars 28 forks source link

Changes nonce to use full alphanumeric charset and appropriate entrop… #8

Closed krhoda closed 2 years ago

krhoda commented 2 years ago

…y levels

sbihel commented 2 years ago

From what I understand, forcing OsRandom isn't strictly needed (I think it is used by default? In any case it is said to be cryptographically secure), but we might want to make that configurable in the future.

krhoda commented 2 years ago

From what I understand, forcing OsRandom isn't strictly needed (I think it is used by default? In any case it is said to be cryptographically secure), but we might want to make that configurable in the future.

Good to know, all changes look good to me -- thanks!