Open TaylorBeeston opened 1 year ago
ssi
is currently in the middle of a major refactor, so we will hold off adding such new feature until it's complete.
A couple of thoughts though after skimming through the PR:
ssi-context
to contexts that everybody would need, so probably the CLR context should be provided by the user; andjsonschema
over boon
, I understand boon
appears to be more complete, but jsonschema
has a larger user base and had been around for a while now.@sbihel no worries! I'll just move the CLR context out of StaticLoader
and then ad hoc use it for the test since I've already got that credential all set up. Should I do the same with the Open Badges contexts?
Also no worries about using jsonschema
instead! I just went here and picked boon because it had more recent commits 😂
I'll go ahead and get started on that now!
Okay, this now uses jsonschema
, does not include CLR V2 context in StaticLoader
, and adds an extra test to make sure that invalid schemas do fail. Let me know if you want me to move OBv3.0.1 and OBv3 Extensions contexts out of StaticLoader
as well!
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Adds support for checking
credentialSchema
.credentialSchema
, that, when specified in options, will check thecredentialSchema
field of a credential.CheckableSchema
enum, similar to theCheckableStatus
enum inssi-vc
that (for now) only supports 1EdTechJSONSchemaValidator2019 schemas, though boon supports much morecredential_schema
test that makes sure everything is working!iri_match
macro, complaining that a comma is missing. I have found that adding a comma like so fixes that:Feel free to remove that comma if necessary, I'm not really sure why it's happening to me as Rust macros still make my brain stop working a bit!
One more bit of reference: These are my cargo/rustc versions I am using and seeing that error with:![image](https://github.com/spruceid/ssi/assets/39720479/6b73ec94-bb81-42f5-939d-482fbb5785bf)