spruceid / ssi

Core library for decentralized identity.
https://spruceid.dev
Apache License 2.0
187 stars 59 forks source link

Credential Schema Support #520

Open TaylorBeeston opened 1 year ago

TaylorBeeston commented 1 year ago

Adds support for checking credentialSchema.

Feel free to remove that comma if necessary, I'm not really sure why it's happening to me as Rust macros still make my brain stop working a bit!

One more bit of reference: These are my cargo/rustc versions I am using and seeing that error with: image

sbihel commented 1 year ago

ssi is currently in the middle of a major refactor, so we will hold off adding such new feature until it's complete.

A couple of thoughts though after skimming through the PR:

TaylorBeeston commented 1 year ago

@sbihel no worries! I'll just move the CLR context out of StaticLoader and then ad hoc use it for the test since I've already got that credential all set up. Should I do the same with the Open Badges contexts?

Also no worries about using jsonschema instead! I just went here and picked boon because it had more recent commits 😂

I'll go ahead and get started on that now!

TaylorBeeston commented 1 year ago

Okay, this now uses jsonschema, does not include CLR V2 context in StaticLoader, and adds an extra test to make sure that invalid schemas do fail. Let me know if you want me to move OBv3.0.1 and OBv3 Extensions contexts out of StaticLoader as well!

CLAassistant commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.