search

spruceid / ssi

Core library for decentralized identity.
https://spruceid.dev
Apache License 2.0
193 stars 61 forks source link

Fixed a bug where an error in a proof verification allowed a positive… #527

Open vdods opened 1 year ago

vdods commented 1 year ago

… Check::Proof to be added to the verification results in addition to the expected error. This fixes it to match the analogous logic in other proof verification code.

vdods commented 1 year ago

This only required fixing a typo. The bug in particular was that I was seeing

VerificationResult { checks: [Proof], warnings: [], errors: [ "signature error: Verification equation was not satisfied" ] }

when I should have been seeing

VerificationResult { checks: [], warnings: [], errors: [ "signature error: Verification equation was not satisfied" ] }
CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

vdods commented 1 month ago

Same deal here, I sent in a signed CLA Oct 6, 2021, but let me know if you need a new one for whatever reason.