spruceid / ssi

Core library for decentralized identity.
https://spruceid.dev
Apache License 2.0
180 stars 54 forks source link

`DateTimeEnvironment` impl for `VerificationEnvironment` is too restrictive #556

Closed ivan770 closed 3 weeks ago

ivan770 commented 3 weeks ago

The following impl block breaks with custom loader types: https://github.com/spruceid/ssi/blob/2446a459876ed673db9f2a0239d807f2e757b60a/crates/claims/core/src/verification/claims.rs#L145-L149

All other impl blocks correctly assume that loaders can be customized: https://github.com/spruceid/ssi/blob/2446a459876ed673db9f2a0239d807f2e757b60a/crates/claims/core/src/verification/claims.rs#L151-L173

timothee-haudebourg commented 3 weeks ago

Good catch, type parameters are missing in the DateTimeEnvironment implementation.