search

spruceid / ssi

Core library for decentralized identity.
https://spruceid.dev
Apache License 2.0
190 stars 60 forks source link

Add support for COSE for VCs. #593

Closed timothee-haudebourg closed 3 weeks ago

timothee-haudebourg commented 1 month ago

This PR adds basic support for COSE_Sign1 and COSE keys using coset and ciborium and implements the COSE part of the JOSE-COSE spec.

Since I needed the base64 library I also upgraded it to the latest version.

timothee-haudebourg commented 3 weeks ago

I've added more doc comments, a couple of examples, and more COSE-key encoding/decoding tests (which is the real addition from coset). I'll try to add the vc-jose-cose-test-suite to didkit-http before the PR is merged, but I'm not against a new review round.

sbihel commented 3 weeks ago

Also, do you think you can try and have a go adding https://github.com/w3c/vc-jose-cose-test-suite/ to didkit-http?

It turns out this test suite hadn't been updated in a while and doesn't use the same system as the other test suites.

scouten-adobe commented 2 weeks ago

Very happy to see this landed. Could you cut a new release with this? (I did my own version, but it was very hacky.)