sprucely-designed / mainwp-discord-notifications

GNU General Public License v3.0
4 stars 1 forks source link

Changelog of this plugin is not shown correctly #13

Open JosKlever opened 1 month ago

JosKlever commented 1 month ago

I noticed that the link of the changelog for this plugin is not correctly shown:

[Discord Webhook Notifications for MainWP](https://github.com/sprucely-designed/mainwp-discord-notifications)
Version 1.1.5 is available.

Author: Isaac @ Sprucely Designed
Description: Sends a message via webhook to a Discord server channel when a plugin or theme update is available.

[View Full Changelog](/sprucely-designed/mainwp-discord-notifications)

The bottom url is incomplete and therefore not transformed into a link.

I couldn't find yet where the url is coming from, so I don't have a PR yet.

sisaacrussell commented 1 month ago

I updated the plugin headers in commit https://github.com/sprucely-designed/mainwp-discord-notifications/commit/405a2a37c1fb966466071639a020418a37a2c776 and that has resulted in the full plugin URI being sent to MainWP. So that at least makes it clickable. Would be nice to figure out how to link that to the changelog from the plugindata but requires more research. image

JosKlever commented 1 month ago

It would be best is a changelog url could be included in the plugin headers, because otherwise you can't automate it.

For this plugin the full changelog url would be https://github.com/sprucely-designed/mainwp-discord-notifications/blob/main/CHANGELOG.md, where /blob/main/CHANGELOG.md could be added to the plugin url, but if other Github plugins use a different filename/location for the changelog, they would still break the link.

This might be interesting to check as well: https://kb.mainwp.com/docs/why-does-my-premium-plugin-not-show-a-changelog-on-mainwp-dashboard/