spruhaN / nutrition_pal

1 stars 1 forks source link

Code Review Comments (Dale Percelay) #18

Open dalepercelay opened 1 month ago

dalepercelay commented 1 month ago

Here are some suggestions:

General: 1- I feel that the muscles covered in this could be expanded to include a more complete set of the body 2- Is there a way to handle unknown calorie values? 3- Is meal input cuisine? Or actual meal, like chicken sandwich. Currently listed as Asian, Mexican, etc. A bit confusing. 4- include more specific values of muscle (back could be at least listed as 3 distinct muscle groups, upper trap, lower trap, lower back, etc.) 5 -I feel this repo could use some strong reorganization for easier readability. 6 - There are no units listed for the measurements, include pounds, kilos, etc. 7 - I do not see the reminders functionality listed in your code yet 8 - your workout endpoint is causing a server error 9 - I would consider separating your main.py into different files for readability. 10 - Could you create a model that shows expected progress? 11 - what should you do in situations where an exercise works mutliple muscles, like a pullup? 12 - You have two schema.sql files, delete the older one no longer in use.