search

sprx97 / OldTimeHockey

Website and scripts for OldTimeHockey fantasy hockey league.
http://www.roldtimehockey.com
3 stars 5 forks source link

Add a search filter with a smoke test file. #96

Closed chrisparsons83 closed 3 years ago

chrisparsons83 commented 3 years ago

What?

Created a search for the leaderboard page. It searches by username or team name.

Why?

Find on mobile is a pain.

How?

All done on frontend, no extra queries to the backend. Filters on the table by setting a hidden class on rows that don't match the pattern so that the ranks don't get updated and are accurate.

Testing?

I added a very basic smoke test to get started on testing. I plan on going back next and working on some more comprehensive tests to work from.

Screenshots

search

Anything Else?

I updated the documentation on setting up the frontend and made it a markdown file for readability. I also moved the original unit test for App.js into the components file since it was failing in its current state.

sprx97 commented 3 years ago

Left some comments asking questions so I can learn but all looks good so I merged.