search

spryker / code-sniffer

Spryker Code Sniffer
https://spryker.com
MIT License
36 stars 11 forks source link

Remove Composer tool related code #334

Closed szepeviktor closed 2 years ago

szepeviktor commented 2 years ago

From #333

spryker/code-sniffer is a Composer package. A user without installed Composer tool cannot participate in this ecosystem.

Proper installation.

I propose to remove all traces and add a link to README: https://getcomposer.org/doc/00-intro.md

@dereuromark Is it okay with you?

dereuromark commented 2 years ago

What is the goal here? To make it easier to get installed without composer? Is that even a thing these days still?

szepeviktor commented 2 years ago

What is the goal here?

To remove Composer tool installation related code from this repository.

Do you think showing how to install Composer (the tool) helps your users?

For example here https://github.com/spryker/code-sniffer/blob/2e92dfa8784110feb3660c9afbdc3e09a9a7f4ef/setup.sh#L5-L6

I think who hasn't got Composer (the tool) installed will not use spryker/code-sniffer

szepeviktor commented 2 years ago

In other words: is there a single person who starts using spryker/code-sniffer before installing Composer on his machine?