search

spryker / code-sniffer

Spryker Code Sniffer
https://spryker.com
MIT License
36 stars 11 forks source link

Remove stray/legacy .license file #336

Closed szepeviktor closed 2 years ago

szepeviktor commented 2 years ago

@dereuromark Is it okay with you?

szepeviktor commented 2 years ago

Oh no! https://github.com/spryker/code-sniffer/blob/acb02cb4cf78dcab323491ea7bc8f5e813adc762/Spryker/Sniffs/Commenting/FileDocBlockSniff.php#L15

Shouldn't the expected file docblock content be in phpcs.xml?

dereuromark commented 2 years ago

We use that file on purpose. As it is needed for our company wide license validation/assertion.

szepeviktor commented 2 years ago

Could you imagine that its content goes inside phpcs.xml? with backward compatibility

dereuromark commented 2 years ago

I dont see why it would need to. lets try to improve this lib, not change things that have little value to change.

szepeviktor commented 2 years ago

not change things that have little value to change.

I'm sorry. I'm a big friend on little values. Actually I care about the foundation (zeros and ones), developers do the pioneer work.

dereuromark commented 2 years ago

Sure, but each change also needs to understand and reflect the environment and BC. Changing this can have some side effects for our existing libraries, so we need to understand the value for such little changes in order not to risk more negative impact than the benefit they bring.

szepeviktor commented 2 years ago

One less file would warm my heart and pay for all negative impacts :)

dereuromark commented 2 years ago

We created and maintain this library of thousands of customers and developers. Keep that in mind, please.

szepeviktor commented 2 years ago

You caught me dreaming! I'm no businessman.