search

spryker / oryx-for-zed

Spryker ZED frontend automation tool (oryx based)
MIT License
0 stars 6 forks source link

spryker/chart causes npm ci to fail #68

Open JonasSeegers opened 3 months ago

JonasSeegers commented 3 months ago

Hi! We've been updating the @spryker/oryx-for-zed npm package. In the docs it says that this requires us to install the spryker/chart module via composer. But if we do, our pipeline fails, because the npm ci command in vendor/spryker/chart/assets/Zed fails with the following error:

npm ERR! Missing: buffer@6.0.3 from lock file
npm ERR! Invalid: lock file's plotly.js@2.26.0 does not satisfy plotly.js@2.27.1
npm ERR! Invalid: lock file's ieee754@1.1.13 does not satisfy ieee754@1.2.1

To reproduce, just run npm ci in the assets/Zed directory of the spryker/chart repository. I can't create an issue in that repo. That's why I'm opening it here. Seems as if the package.json and package-lock.json are out of sync. If you run npm i first, it works

npm version is 10.7.0 node version is 20.13.1

jbtcd commented 1 month ago

Hey! I have the same problems with some other packages.

In https://github.com/spryker/gui and https://github.com/spryker/discount I also need a npm i to run npm ci on the main repo.

Currently, as a quickfix I added some install commands to be able to deploy my application with vendor/bin/console frontend:zed:install-dependencies:

npm --prefix vendor/spryker/chart/assets/Zed i
npm --prefix vendor/spryker/gui/assets/Zed i
npm --prefix vendor/spryker/discount/assets/Zed i

But this should not be the solution, are there plans to solve the problem, and if so, by when?