search

sps / mustache-spring-view

java spring framework mvc view for Mustache.js templates
68 stars 31 forks source link

Missing dependency for 'com/google/common/base/Objects'? #26

Open SkyCrawl opened 6 years ago

SkyCrawl commented 6 years ago

Hello,

thanks for working on this.

My issue is that with the following dependencies defined in Gradle:

compile 'com.samskivert:jmustache:1.13'
compile 'com.github.sps.mustache:mustache-spring-view:1.4'
compile 'com.github.spullara.mustache.java:compiler:0.9.5'

I'm getting the following runtime exception:

Caused by: java.lang.NoClassDefFoundError: com/google/common/base/Objects
    at org.springframework.web.servlet.view.mustache.java.MustacheJTemplateFactory.<init>(MustacheJTemplateFactory.java:49)

It seems to me like a dependency to the google-collections library is missing in the README. Anyway, I don't mean to criticize (we are all lazy after all) but is it really worth introducing this dependency for a single use of the firstNonNull function, especially if I'm right and the library is so old?