search

sps / mustache-spring-view

java spring framework mvc view for Mustache.js templates
68 stars 31 forks source link

Allow referencing segments directly #6

Closed smokku closed 11 years ago

smokku commented 11 years ago

Fix with prefix and suffix only if direct path is unavailable.

sps commented 11 years ago

This seems to break convention and involves the in worst case 2 I/O operations per template load. Given that you configure the view a prefix and/or suffix, it seems odd to disregard these first and then append them if the file doesn't exist. I would be more ok with this if it was inverted (file with prefix/suffix first, then fall back to direct file name).

smokku commented 11 years ago

Ouch. 6 months ago... I don't even remember what was that change needed for and is the reason still valid. ;-)

Let's just close this pull request and if I would remember the reason, I would rewrite it as requested and open another pull request, or just reopen this one with a comment.

sps commented 11 years ago

Thanks and sorry for the delay on responding to this. I am trying to clean up the issues queue on this project.