search

sps / pushover4j

pushover.net client
Apache License 2.0
35 stars 28 forks source link

Add Support for HTML Formattet Messages by adding a new Method #9

Closed JKarthaus closed 8 years ago

JKarthaus commented 8 years ago

Pushover supports HTML Message Styling since Version 2.3 Pushover Documentation

I add the Medthod setHtmlMessage("<b>testing!</b>") for sending HTML Styled Messages

hhocker commented 8 years ago

Joern, thanks for the pull request. I am concerned that the implementation of the HTML parameter may not be correct. To do html it looks as if you don't do the parameter in the URL but as another JSON object in the key-value pairs. Unless you tested and found that the parameter goes in the URL. I can see where your method works well to take advantage of the HTML formatting but I think the request is not ready.

See my comments in the files changed on how to improve this unless you can show that it only works the other way.

JKarthaus commented 8 years ago

OK both Variants work, but setting the Parameter as Name Value Pair is more correct.