Update for changes coming to rsample

[hfrick]

Hello!

I maintain the rsample package and we are changing initial_time_split() to error with arguments passed via .... This breaks one of the examples in healthR.ts which this PR fixes by removing the (unused) argument cumulative.

The changes in rsample: https://github.com/tidymodels/rsample/pull/429

[hfrick]

Thanks!

[hfrick]

Just a heads-up: I'm preparing a rsample release and it breaks the CRAN version of healthyR.ts because this fix wasn't part of its latest CRAN release.

[spsanderson]

@hfrick I released the merge you made on April 21st into CRAN on June 25th so I think I should be fine.

[hfrick]

Hm, the manual currently on CRAN does include the cumulative = TRUE argument to initial_time_split() in the example to ts_auto_recipe() so I don't think the change made it to CRAN. The release notes here also read like this fix wasn't part of it: https://github.com/spsanderson/healthyR.ts/releases/tag/v0.2.9

[spsanderson]

🤔 ok I’ll look immediately thank youSent from my iPhonewww.spsanderson.comOn Aug 21, 2023, at 12:20 PM, Hannah Frick @.***> wrote: Hm, the manual currently on CRAN does include the cumulative = TRUE argument to initial_time_split() in the example to ts_auto_recipe() so I don't think the change made it to CRAN. The release notes here also read like this fix wasn't part of it: https://github.com/spsanderson/healthyR.ts/releases/tag/v0.2.9

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

[spsanderson]

@hfrick that is indeed strange as the code example on github does not have it. I will just re-release citing the merge you made as the change in the NEWS file.

[hfrick]

Awesome, thank you!

[spsanderson]

I have submitted a release to CRAN