spsaswat / APPF_FLIR

AI Forward-looking infrared (FLIR) imaging
Mozilla Public License 2.0
8 stars 4 forks source link

Calibrate D405 and Thermal camera #20

Closed spsaswat closed 4 months ago

spsaswat commented 5 months ago

https://github.com/spsaswat/APPF_FLIR/blob/main/SensorCommunication/Acquisition/calib_data.zip 1) use code to focus on these circles from both the camera (actual diameter 30mm), and make all other pixels black.: image image 2) try calibrating by aligning images to the centre of the circles.

you don't need to calibrate the depth image.

spsaswat commented 4 months ago

please recalibrate and align so that we can have maximum common region between the two cameras

zzzshuang commented 4 months ago

Hi Saswat@spsaswat, i've updated the calibration code to allow detection of the blue bounding box on RGB images without cropping, and create a mask to cover irrelevant areas. Please take a moment to review it.

mdchia commented 4 months ago

Hardcoded paths (e.g. https://github.com/spsaswat/APPF_FLIR/blob/1d4643a8c13d0d65419fd623beff57c1aa4d76ae/camera_calibration.py#L159 ) should be refactored into a script argument or maybe folder config variable (if it expects a particular folder structure, that should be documented)

zzzshuang commented 4 months ago

Hi, i reconstructed the calibration code, kindly review it please.