search

spuder / puppet-gitlab

A puppet module to install gitlab 7
Apache License 2.0
36 stars 44 forks source link

Use maestrodev/wget #119

Closed ghoneycutt closed 9 years ago

ghoneycutt commented 9 years ago

Without this patch, you cannot use this module if you have wget previously declared. This uses maestrodev/wget which is a Puppet Labs Approved module.

ghoneycutt commented 9 years ago

@spuder Does this look good? If so, I'm happy to update the spec tests.

spuder commented 9 years ago

Thanks for the pull request. I'm hesitant to add dependencies to other modules since it adds additional complexity.

There is a parameter which is specifically designed for those who manage postfix, ssh and wget with other modules. If you set puppet_manage_packages => false then the packages.pp manifest will not be loaded, and you won't get the duplicate resource declaration.

The module aims to be use for both people who want to quickly get up and running in a masterless mode, and for those with complex infrastructures.

Is there a use case where the puppet_manage_packages parameter wouldn't work for you?

spuder commented 9 years ago

On second look, I notice that the wget package is actually included in the install.pp, not the packages.pp so the work around suggested will not work. If I remember correctly, this was done on purpose because resources are not contained to their classes.

However, I still think the wget puppet module is overkill since none of the defined resource types provided by that module are used.

Does this code work for you?

spuder commented 9 years ago

I'm going to close this in favor of this pull request

https://github.com/spuder/puppet-gitlab/pull/102

Instead of hard coding a dependency on wget, it will instead use curl inside of the optional packages.pp