search

spuder / puppet-gitlab

A puppet module to install gitlab 7
Apache License 2.0
36 stars 44 forks source link

fixes missing ssl_certificate when redirect_http_to_https #127

Closed timhughes closed 9 years ago

timhughes commented 9 years ago

fixes #126

spuder commented 9 years ago

I'd like to merge this, but I want to fix travis first so we can see if there are any big regressions.

spuder commented 9 years ago

Travis is still broken. Whats your confidence on this merge?

timhughes commented 9 years ago

Pretty confident, the tests i wrote were passing but I will take another look with a fresh mind. On 29 Apr 2015 12:01 am, "Spencer Owen" notifications@github.com wrote:

Travis is still broken. Whats your confidence on this merge?

— Reply to this email directly or view it on GitHub https://github.com/spuder/puppet-gitlab/pull/127#issuecomment-97254003.

timhughes commented 9 years ago

I have had another look and I cannot see any issues. It works on my systems and I am pretty sure that the tests cover the requirements.

spuder commented 9 years ago

Great, I'll run some more testing on this. Thanks

igalic commented 9 years ago

@timhughes any news on this?

timhughes commented 9 years ago

@igalic As far as I am concerned this is good to go. The tests cover what I think the logic should be and they pass. I keep trying to get some work time to help @spuder clean up the rest of the travis tests so that he is happy to merge it but so far I haven't had the time.

spuder commented 9 years ago

Module transitioned to here: https://github.com/vshn/puppet-gitlab