search

spuder / puppet-gitlab

A puppet module to install gitlab 7
Apache License 2.0
36 stars 44 forks source link

backup_upload_remote_directory needs to be put into single quotes in gitlab.rb #128

Closed judge-red closed 9 years ago

judge-red commented 9 years ago

If backup_upload_remote_directory is not put into single quotes, it can cause issues with GitLab like this: Notice: /Stage[main]/Gitlab::Config/Exec[/usr/bin/gitlab-ctl reconfigure]/returns: NoMethodError Notice: /Stage[main]/Gitlab::Config/Exec[/usr/bin/gitlab-ctl reconfigure]/returns: ------------- Notice: /Stage[main]/Gitlab::Config/Exec[/usr/bin/gitlab-ctl reconfigure]/returns: undefined method `example' for nil:NilClass

(that is an example where backup_upload_remote_directory is set to 'gitlab.example.com-backup' (S3 bucket).

judge-red commented 9 years ago

This CI errors don't see to be related, are they? Sorry, I'm not really a programmer myself, just trying to fix something small here.

spuder commented 9 years ago

The CI errors started happening before. I haven't been able to test the backup_upload_remote_directory since I don't use that feature. Does this merge request fix the issue for you?

judge-red commented 9 years ago

Yes, this does fix the issue for me. Thanks for merging it.