spuder / puppet-gitlab

A puppet module to install gitlab 7
Apache License 2.0
36 stars 44 forks source link

Check if wget is previously installed #133

Closed Ddall closed 9 years ago

Ddall commented 9 years ago

This prevents the error when wget is managed by another class: Error: Duplicate declaration: Package[wget] is already declared; cannot redeclare at /etc/puppet/modules/gitlab/manifests/install.pp:183

This will solve this issue: https://github.com/spuder/puppet-gitlab/issues/132

b4ldr commented 9 years ago

This is dependent on parse order. if the wget package is defined after the gitlab module runs then your will still see an error. A better option would be to manage the installation of this package via the

$gitlab::puppet_manage_packages variable

or have a variable such fetch_client which defines the system binary to use; ensuring you don't need to install a package. See here https://github.com/xaque208/puppet-unbound/blob/master/manifests/params.pp

spuder commented 9 years ago

Fixed in #134