search

spuder / puppet-gitlab

A puppet module to install gitlab 7
Apache License 2.0
36 stars 44 forks source link

Add unicorn worker settings. #147

Closed andrekeller closed 9 years ago

andrekeller commented 9 years ago

Add possibility to configure unicorn worker settings.

andrekeller commented 9 years ago

Hi,

I will gladly add the tests.

default for timeout is 60, default for processes is nvcpu + 1, I'll add it to the pull request,

andrekeller commented 9 years ago

I rebased branch. Please advice if you'd like any further changes.

spuder commented 9 years ago

Thanks, looks great.

Typically I've made the examples in the documentation match the default values. Is that something you could change quickly? If not, I can merge this as is.

andrekeller commented 9 years ago

ok, i fixed the timeout value. For the example of the processes I now use consistently 5. This is default if you have 4 cores. Other possibility would be to use something like 1 + $::processorcount. I'm not sure whats the better approach.

spuder commented 9 years ago

Great pull request, thanks so much.