spuithori / tokimekibluesky

https://tokimeki.blue
MIT License
163 stars 19 forks source link

Embed a feed url as record instead of link #100

Open robpc opened 1 day ago

robpc commented 1 day ago

When embedding a link to a feed in Tokimeki, the app adds it as an external link instead of as a record, which does not let the client properly fill in the details.


Tokimeki created post

{
  // ...
  "embed": {
    "$type": "app.bsky.embed.external",
    "external": {
      "description": "",
      "title": "Bluesky",
      "uri": "https://bsky.app/profile/did:plc:gkvpokm7ec5j5yxls6xk4e3z/feed/formula-one"
    }
}
Screenshot 2024-11-15 235335

Bluesky app created post

{
  // ...
  "embed": {
    "$type": "app.bsky.embed.record",
    "record": {
      "cid": "bafyreiaqhuwxhaprq4wqiwhc3sztxwo2uiddes2ih7rrqd5nie3v6f7gsy",
      "uri": "at://did:plc:gkvpokm7ec5j5yxls6xk4e3z/app.bsky.feed.generator/formula-one"
    }
  }
}
Screenshot 2024-11-15 235630
spuithori commented 1 day ago

@robpc Hi! Embedding a feed can be done from the '...' menu on the feed card. To maintain consistency in behavior, I want to treat all inserted links as external links.

image
robpc commented 1 day ago

@spuithori thanks for the reply. I appreciate getting your reasoning. I have a couple thoughts though.

1) the official app is context aware and just "handles it" so that makes this behavior unexpected 2) I am not sure of an easy way to do that when replying to something (like in the screenshot below)

Screenshot 2024-11-16 012450

EDIT: I can sort of see how that works if you happen to have both things up on your deck at the same time... wondering how that could be easier... maybe if that menu item was also in the column title?

Screenshot 2024-11-16 013807
robpc commented 1 day ago

Or maybe better yet a new toolbar item in the post editor with all your profile feeds as a menu? I do like that I don't have to delete the link lol.

spuithori commented 1 day ago

@robpc It is possible to embed a feed at the same time while embedding a reply. Even if you close the post composer, the draft will not be deleted (unless you reload the page). Adding a feed embed button to the column is a good idea! I would like to implement this.