Effectively dead code in Dockerfile?

spujadas / lighttpd-docker

Docker image for lighttpd, a secure, fast, compliant, and flexible web server

MIT License

59 stars 66 forks source link

Effectively dead code in Dockerfile? #19

Closed hartwork closed 4 years ago

hartwork commented 4 years ago

Hi! It came to my attention that at …

https://github.com/spujadas/lighttpd-docker/blob/3cfc6cf5058b226199761fc9256d10e40337f584/Dockerfile#L12-L16

… file /etc/lighttpd/lighttpd.conf is extended and then overritten by COPY etc/lighttpd/* /etc/lighttpd/. Unless I am missing soemthing, the RUN line can be dropped. True?

spujadas commented 4 years ago

Embarrassingly, this has been here for a very long time and I'd never noticed it before 😅 You're absolutely right, the RUN ... line shouldn't be there, a) because it is indeed overwritten, and b) because the server.network-backend = "writev" is in lighttpd.conf anyway. Will update the Dockerfile.