search

spulec / freezegun

Let your Python tests travel through time
Apache License 2.0
4.15k stars 269 forks source link

Only mock asyncio on request #525

Closed bblommers closed 9 months ago

bblommers commented 10 months ago

Partially reverts #470

Fixes #521 Fixes #522

@marcinsulikowski @boxed As the people that were originally involved with #470 - do you have any problems with this change, to gatekeep this behaviour behind a flag?

The linked issues indicate that this introduced quite some unintended side effects. Hiding this behaviour behind a flag keeps the feature accessible, but also doesn't break everything for others.

I'm torn whether this constitutes a breaking change, or a bugfix. Considering the amount of stuff it seems to break, I may just release it as a new minor version.

spt29 commented 9 months ago

I would very much appreciate this change: We had literally dozens of failures in our test runs due to the change in behaviour, so I would consider this change here as a bug fix. If one really needs the asyncio stuff, an explicit opt-in looks right. Otherwise pinning to 1.2.2 seems to be the only sane option for us at the moment. :disappointed: