* partial implementation of netty 4 client + refactoring on Reply inheritance tree

[gbrd]

• partial implementation of netty 4 client (some verbs are missing, need just some more copy-paste)
• refactoring on Reply inheritance tree
• fix some issues (workarround for netty bug in fact) on message order over intense usage of message pipelining
• some other minor modifications

[normanmaurer]

If there is a Netty bug please open an issue in the Netty issue tracker ...

Am 23.04.2014 um 16:36 schrieb gbrd notifications@github.com:

partial implementation of netty 4 client (some verbs are missing, need just some more copy-paste) refactoring on Reply inheritance tree fix some issues (workarround for netty bug in fact) on message order over intense usage of message pipelining some other minor modifications You can merge this Pull Request by running

git pull https://github.com/gbrd/redis-protocol master Or view, comment on, or merge it at:

https://github.com/spullara/redis-protocol/pull/36

Commit Summary

• partial implementation of netty 4 client (some verbs are missing, File Changes

M .gitignore (11) M README (8) D netty4-client/src/main/java/redis/netty4/ChannelFutureListenerPromiseAdapter.java (28) A netty4-client/src/main/java/redis/netty4/RedisClient.java (738) D netty4-client/src/main/java/redis/netty4/RedisClientBase.java (60) M netty4-client/src/test/java/redis/netty4/RedisClientTest.java (234) M netty4-server/src/main/java/redis/server/netty/RedisCommandDecoder.java (2) M netty4-server/src/main/java/redis/server/netty/SimpleRedisServer.java (14) A netty4/src/main/java/redis/netty4/AbstarctReply.java (25) A netty4/src/main/java/redis/netty4/AbstractRedisDecoderState.java (105) M netty4/src/main/java/redis/netty4/BulkReply.java (42) M netty4/src/main/java/redis/netty4/Command.java (40) A netty4/src/main/java/redis/netty4/CommandResp.java (89) M netty4/src/main/java/redis/netty4/ErrorReply.java (20) A netty4/src/main/java/redis/netty4/IRedisDecoderState.java (15) A netty4/src/main/java/redis/netty4/InAMultiBulkDecoderState.java (49) A netty4/src/main/java/redis/netty4/InitialRedisDecoderState.java (120) M netty4/src/main/java/redis/netty4/InlineReply.java (19) M netty4/src/main/java/redis/netty4/IntegerReply.java (18) M netty4/src/main/java/redis/netty4/MultiBulkReply.java (244) A netty4/src/main/java/redis/netty4/RedisException.java (29) M netty4/src/main/java/redis/netty4/RedisReplyDecoder.java (189) M netty4/src/main/java/redis/netty4/Reply.java (10) A netty4/src/main/java/redis/netty4/ReplyListener.java (14) M netty4/src/main/java/redis/netty4/StatusReply.java (20) R netty4/src/test/java/redis/netty4/CommandTest.java (4) R netty4/src/test/java/redis/netty4/ReplyTest.java (32) M pom.xml (314) Patch Links:

https://github.com/spullara/redis-protocol/pull/36.patch https://github.com/spullara/redis-protocol/pull/36.diff — Reply to this email directly or view it on GitHub.

[gbrd]

I would have to try it again on last netty version. With netty 4.0.15 it seems I was forced to wait for write callback (ChannelFuture completed) to be sure that commands are sent in order on the TCP connection. Sometime, I had problems if I just try to rely on synchronous write return, but the conditions to reproduce it were not clear.

[gbrd]

I reformatted the code (with 2 spaces) and cleaned previous commit.